Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update passing of initial props on android #2485

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Update passing of initial props on android #2485

merged 1 commit into from
Jul 20, 2020

Conversation

mchowning
Copy link
Contributor

Please see the related WPAndroid PR for information about this PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@mchowning mchowning added this to the 1.34 milestone Jul 14, 2020
@mchowning mchowning self-assigned this Jul 14, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 14, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mchowning mchowning mentioned this pull request Jul 14, 2020
Merged
3 tasks
@mchowning mchowning changed the title Update gutenberg submodule Update passing of initial props on android Jul 14, 2020
cameronvoell
cameronvoell approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Tested via WPAndroid and Gutenberg PRs.

@mchowning mchowning force-pushed the update_passing_of_initial_props_on_android branch from 6d298a8 to 4a6b5b1 Compare July 20, 2020 21:13
@mchowning mchowning force-pushed the update_passing_of_initial_props_on_android branch from 4a6b5b1 to bcfad45 Compare July 20, 2020 21:20
@mchowning mchowning merged commit eee29ca into develop Jul 20, 2020
@mchowning mchowning deleted the update_passing_of_initial_props_on_android branch July 20, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@chipsnyder chipsnyder Awaiting requested review from chipsnyder

@mkevins mkevins Awaiting requested review from mkevins

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@mchowning mchowning

Labels
[Type] Technical Debt
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @cameronvoell