Have release script open Gutenberg PR #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
This looks amazing 🎉 Thank you so much @mchowning! Just have a small suggestion for better readability. Can't wait to try it!
Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com>
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com>
|
Thanks for the suggestions @ceyhun! I do like how that makes it much clearer what the script is doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds opening the gutenberg release PR to the release automation script. In doing that, it automatically includes a link to the gb-mobile PR in the gutenberg PR description. In addition, it prints the list of opened PRs at the end of the script.
Assuming this works well, I think it should be relatively straightforward to add the WPiOS and WPAndroid PRs to this script as well. But I figured we should see how this works first.
To test:
Make sure the release script runs smoothly and opens draft PRs in gb && gb-mobile with appropriately updated branches.
PR submission checklist: