-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React Native to 0.63 #2580
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gutenberg # package.json
This was referenced Aug 27, 2020
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This was referenced Nov 17, 2020
Regarding the above, see attached log showing the crash on Android. |
This was referenced Apr 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade React Native to version 0.63.2
Gutenberg PR: WordPress/gutenberg#24872
WordPress-Android: wordpress-mobile/WordPress-Android#12816
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#14776
react-native-svg PR: wordpress-mobile/react-native-svg#11
react-native-video PR: wordpress-mobile/react-native-video#9
react-native-keyboard-aware-scroll-view PR: wordpress-mobile/react-native-keyboard-aware-scroll-view#11
To test: Gutenberg Editor should work as expected.
Try to run all the manual tests.
Known Issues:
On Android demo app cannot type anything to RichText blocksOn iOS demo app not possible to dismiss keyboard with the button on top rightRN patch in gutenberg needs to be updated (react-native+0.62.2.patch)RN patches in WPiOS needs to be updated (RCTActionSheetManager.patch, etc.)PR submission checklist: