Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GB hash and update package-lock.json, plus fix Memory issue on CI #2960

Merged
merged 23 commits into from
Jan 7, 2021
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cd74d02
Bump Gutenberg ref
hypest Jan 5, 2021
ceaddbe
Update package-lock.json
hypest Jan 5, 2021
7589573
Commit package lock change after additional npm install run
hypest Jan 5, 2021
23e109c
Remove and re-add @wordpress/eslint-plugin to fix missing plugin errors
ceyhun Jan 5, 2021
6990c57
Resolve packages inside gutenberg and gutenberg/node_modules as well
ceyhun Jan 5, 2021
3cc6740
Add gutenberg/package.json to also get checked for imported packages
ceyhun Jan 5, 2021
e10d3e1
Build gutenberg packages before linting
ceyhun Jan 6, 2021
b1e1cc9
Remove unused moduleDirectory option
ceyhun Jan 6, 2021
edb83d8
Uninstall unused @wordpress/ packages
ceyhun Jan 6, 2021
3a24b7b
Increase node memory when building packages
ceyhun Jan 7, 2021
49d0edc
Remove additional node memory when building packages
ceyhun Jan 7, 2021
ad3fae2
Only run check correctness job
ceyhun Jan 7, 2021
e1e1592
Revert "Remove additional node memory when building packages"
ceyhun Jan 7, 2021
fd5c265
Revert "Revert "Remove additional node memory when building packages""
ceyhun Jan 7, 2021
5198ef4
Use linux machine, which has more memory
ceyhun Jan 7, 2021
9743ee3
Fix linux image name
ceyhun Jan 7, 2021
e3265fc
Try single line command
ceyhun Jan 7, 2021
c11a6d3
Install newer nvm
ceyhun Jan 7, 2021
a599e73
Debug CI
ceyhun Jan 7, 2021
dfaf6d8
Load nvm another way
ceyhun Jan 7, 2021
894ce0f
Separate nvm installation from node installation
ceyhun Jan 7, 2021
de4b3dd
Remove unused import
ceyhun Jan 7, 2021
9200978
Revert "Only run check correctness job"
ceyhun Jan 7, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,17 @@ module.exports = {
],
extends: [
"plugin:@wordpress/eslint-plugin/recommended",
]
],
settings: {
'import/resolver': {
'node': {
'moduleDirectory': ['node_modules', 'gutenberg/node_modules']
}
},
},
rules: {
// do not throw an error if imported dependencies are
// declared in `package.json` or `gutenberg/package.json`
"import/no-extraneous-dependencies": ["error", {"packageDir": ['.', './gutenberg/']}]
}
};
1 change: 1 addition & 0 deletions bin/ci-checks-js.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ fi

if [ "$CHECK_CORRECTNESS" = true ] ; then
checkDiff
npm run build --prefix gutenberg || pFail # Need to build gutenberg packages before linting so that eslint-plugin-import can resolve those.
npm run lint || pFail
fi

Expand Down
2 changes: 1 addition & 1 deletion gutenberg
Submodule gutenberg updated 218 files
Loading