Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio block - UI fixes #3118

Merged
merged 5 commits into from
May 21, 2021
Merged

Audio block - UI fixes #3118

merged 5 commits into from
May 21, 2021

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Feb 9, 2021 •
edited
Loading

gutenberg PR WordPress/gutenberg#28867
WP Android wordpress-mobile/WordPress-Android#14007
To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Feb 9, 2021
Closed
Merged
Merged
@jd-alexander jd-alexander marked this pull request as ready for review February 9, 2021 05:26
@jd-alexander jd-alexander requested a review from ceyhun February 9, 2021 05:26
ceyhun
ceyhun approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#28867

@jd-alexander jd-alexander force-pushed the fix/audio-block-ui-fixes branch from 21c2693 to 646d5c4 Compare May 20, 2021 03:23
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 20, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander jd-alexander added this to the 1.54.0 (17.5) milestone May 21, 2021
@jd-alexander jd-alexander enabled auto-merge May 21, 2021 06:13
@jd-alexander jd-alexander merged commit b14617f into develop May 21, 2021
@jd-alexander jd-alexander deleted the fix/audio-block-ui-fixes branch May 21, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees
No one assigned
Labels
Audio block
Projects
None yet
Milestone
1.54.0 (17.5)
Development

Successfully merging this pull request may close these issues.
2 participants
@jd-alexander @ceyhun