Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Improve Text Entry for Long Alt Text #3236

Merged
merged 12 commits into from
Apr 2, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Mar 9, 2021

Fixes: #922

gutenberg: WordPress/gutenberg#29670

Description

With this PR, a new AltTextSettings component has been introduced to replace the current TextControl that exists for entering an image's Alt text. This new component makes use of BottomSheet.SubSheet so that users are taken to a new subsheet when entering alt text.

The end goal is to provide a better experience for users who are entering a longer alt text for their images, as the current text entry has limited room/options for scrolling.

How has this been tested?

The general steps for testing, for both iOS and Android, are as follows:

  1. Open Image Block settings.
  2. Tap Alt Text and confirm that a new sub sheet opens with a text editor.
  3. Enter text into editor and tap the back arrow.
  4. Confirm that the image's alt text has been correctly updated by viewing the placeholder displayed alongside Alt Text in the settings panel. This can be further verified by saving changes and confirming the alt text has been correctly updated on the web.

As this is a UI change, I have also tested with dark mode enabled and in landscape mode.

Please see Gutenberg PR for additional details, screenshots, and comments.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This commit updates the Gutenberg reference to include the latest changes.
This commit updates the reference to Gutenberg to include the latest changes.
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 9, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I approved the GB pr here: WordPress/gutenberg#29670 (review)
If no further changes are needed design-wise, I think this is ready to merge (you'll have to add something to the release notes here, too!)

@hypest
Copy link
Contributor

hypest commented Apr 2, 2021

GitHub reports that gutenberg is conflicting, which is not the case. I will update from develop anyway to see if that fixes the issue.

Edit: it did fix the complain, and the diff is still correct (only change to the Gutenberg hash, pointing to WordPress/gutenberg@c508c1b as it needs to so, all good 👍. Will enable "merge when CI green".

@hypest hypest enabled auto-merge April 2, 2021 08:14
@hypest hypest merged commit dd516c3 into develop Apr 2, 2021
@hypest hypest deleted the update/text-entry-for-alt-text-field branch April 2, 2021 08:36
@dcalhoun dcalhoun mentioned this pull request Apr 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image block: Improve text entry for long text in the image settings bottom sheet
3 participants