-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Block: Improve Text Entry for Long Alt Text #3236
Conversation
This commit updates the Gutenberg reference to include the latest changes.
This commit updates the reference to Gutenberg to include the latest changes.
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I approved the GB pr here: WordPress/gutenberg#29670 (review)
If no further changes are needed design-wise, I think this is ready to merge (you'll have to add something to the release notes here, too!)
GitHub reports that Edit: it did fix the complain, and the diff is still correct (only change to the Gutenberg hash, pointing to WordPress/gutenberg@c508c1b as it needs to so, all good 👍. Will enable "merge when CI green". |
Fixes: #922
gutenberg
: WordPress/gutenberg#29670Description
With this PR, a new
AltTextSettings
component has been introduced to replace the currentTextControl
that exists for entering an image's Alt text. This new component makes use ofBottomSheet.SubSheet
so that users are taken to a new subsheet when entering alt text.The end goal is to provide a better experience for users who are entering a longer alt text for their images, as the current text entry has limited room/options for scrolling.
How has this been tested?
The general steps for testing, for both iOS and Android, are as follows:
As this is a UI change, I have also tested with dark mode enabled and in landscape mode.
Please see Gutenberg PR for additional details, screenshots, and comments.
PR submission checklist: