Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - Bottom Sheet - Move back icon to component folder #3456

Merged
merged 3 commits into from
May 5, 2021

Conversation

geriux
Copy link
Contributor

@geriux geriux commented May 4, 2021

Gutenberg PR -> WordPress/gutenberg#31467

Moves the back button (chevronBackiOS) used in the Bottom Sheet from the icons library to the component's folder. Since this icon is only being used on mobile and only for iOS.

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via gutenberg PR 🎉

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 5, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux merged commit 5bdbf53 into develop May 5, 2021
@geriux geriux deleted the move-bottom-sheet-icon branch May 5, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants