Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio block URL Parser unit tests #3524

Merged
merged 4 commits into from
May 21, 2021
Merged

Audio block URL Parser unit tests #3524

merged 4 commits into from
May 21, 2021

Conversation

jd-alexander
Copy link
Contributor

Fixes #3433

To test:
WordPress/gutenberg#31920
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander mentioned this pull request May 19, 2021
Merged
7 tasks
@jd-alexander jd-alexander marked this pull request as ready for review May 19, 2021 04:46
@jd-alexander jd-alexander requested a review from fluiddot May 19, 2021 04:47
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 20, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

fluiddot
fluiddot approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#31920 (review).

Base automatically changed from add/audio-block-IV-from-url to develop May 21, 2021 05:45
@jd-alexander jd-alexander added this to the 1.54.0 (17.5) milestone May 21, 2021
@jd-alexander jd-alexander added Audio block Testing Anything related to automated tests labels May 21, 2021
@jd-alexander jd-alexander enabled auto-merge May 21, 2021 06:12
@jd-alexander jd-alexander merged commit ec46aeb into develop May 21, 2021
@jd-alexander jd-alexander deleted the add/audio-block-IV-from-url-unit-tests branch May 21, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
Audio block Testing Anything related to automated tests
Projects
None yet
Milestone
1.54.0 (17.5)
Development

Successfully merging this pull request may close these issues.

[Audio block] Create unit tests for Add From URL's url parser for filename
2 participants
@jd-alexander @fluiddot