-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block inserter onboarding tooltip #3529
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponding Gutenberg PR Approved.
Hey @dcalhoun 👋 Looks like some of the slash inserter tests are not passing with these changes, could you please check them out? Thanks! |
@geriux they appeared to be the same two tests that were failing inconsistently for others as well. I ran them locally and they passed, so I'm not sure if it's a valid failure or flakiness at this time. I have rerun them multiple times on the PR with no success. I will take a deeper look in a couple of hours when I come online for the day. 👍🏻 |
I'll double check too 👍 |
Hey @dcalhoun . We will cut the 1.54.0 release later today. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.54.0. Thanks! |
Fixes WordPress/gutenberg#30624. Add tooltip for the block inserter as a part of a larger editor onboarding experience.
To test: See test plan within WordPress/gutenberg#32001.
PR submission checklist: