Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inserter menu tabs rendering #3543

Merged
merged 4 commits into from
May 26, 2021
Merged

Fix inserter menu tabs rendering #3543

merged 4 commits into from
May 26, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 24, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#32149

To test:
Check testing instructions from gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label May 24, 2021
@fluiddot fluiddot added this to the 1.54.0 (17.5) milestone May 24, 2021
@fluiddot fluiddot self-assigned this May 24, 2021
@fluiddot fluiddot mentioned this pull request May 24, 2021
Merged
7 tasks
@fluiddot fluiddot requested review from geriux and guarani May 24, 2021 12:13
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 24, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

geriux
geriux approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#32149 (review)

@fluiddot fluiddot merged commit 24df728 into develop May 26, 2021
@fluiddot fluiddot deleted the fix/inserter-menu-tabs-render branch May 26, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

@guarani guarani Awaiting requested review from guarani

Assignees

@fluiddot fluiddot

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.54.0 (17.5)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @geriux