Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean i18n cache command #4469

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Add clean i18n cache command #4469

merged 2 commits into from
Jan 14, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 14, 2022

Adds a clean command for removing the i18n cache.

To test:

  1. Run command npm run clean.
  2. Observe that the folder src/i18n-cache is removed.
  3. Run command npm run ci.
  4. Observe that the folder src/i18n-cache is created and contains translation files for supported plugins: Gutenberg (gutenberg folder) , Jetpack (jetpack folder) and Layout Grid (layout-grid folder).

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Enhancement Improves a current area of the editor label Jan 14, 2022
@fluiddot fluiddot self-assigned this Jan 14, 2022
@fluiddot fluiddot requested review from antonis and guarani January 14, 2022 17:04
# ignore all the contents of this folder except .gitignore and index.js
*
!.gitignore
!index.js
Copy link
Contributor Author

@fluiddot fluiddot Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is no longer required as it was removed in this PR.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working great!

.gitignore Show resolved Hide resolved
@fluiddot fluiddot merged commit 6642e84 into develop Jan 14, 2022
@fluiddot fluiddot deleted the add/clean-i18n-cache branch January 14, 2022 17:56
@fluiddot fluiddot added this to the 1.70.0 (19.1) milestone Jan 14, 2022
package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants