Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address failing mobile tests #4776

Closed
wants to merge 9 commits into from
Closed

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Apr 20, 2022

Fixes a recent breakage in the native build, which can be viewed here: https://app.circleci.com/pipelines/github/wordpress-mobile/gutenberg-mobile/17096/workflows/37583660-a955-4550-ac07-9fdab16dd5b8/jobs/93001

The error logs associated with this breakage can be viewed here, and is related to files that were moved in #23817. ⤵︎
error jetpack/projects/plugins/jetpack/extensions/shared/icons.scss: @**********/jetpack-base-styles/gutenberg-base-styles could not be resolved in /home/circleci/project/jetpack/projects/plugins/jetpack/extensions/shared/@**********/jetpack-base-styles,/home/circleci/project,jetpack/projects/plugins/jetpack/extensions/shared,/home/circleci/project/gutenberg/packages/react-native-editor/src,/home/circleci/project/gutenberg/packages/base-styles
  ╷
9 │ @import '@**********/jetpack-base-styles/gutenberg-base-styles';
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  stdin 9:9  root stylesheet.
Error: @**********/jetpack-base-styles/gutenberg-base-styles could not be resolved in /home/circleci/project/jetpack/projects/plugins/jetpack/extensions/shared/@**********/jetpack-base-styles,/home/circleci/project,jetpack/projects/plugins/jetpack/extensions/shared,/home/circleci/project/gutenberg/packages/react-native-editor/src,/home/circleci/project/gutenberg/packages/base-styles
  ╷
9 │ @import '@**********/jetpack-base-styles/gutenberg-base-styles';
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  stdin 9:9  root stylesheet

Related PRs

Testing

Please refer to the Jetpack PR for the most up-to-date description and testing instructions.


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 20, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB changed the title Update reference to Jetpack Address failing mobile tests Apr 20, 2022
@SiobhyB SiobhyB added the Jetpack Bug or feature related to Jetpack label Apr 20, 2022
@SiobhyB SiobhyB self-assigned this Apr 20, 2022
@SiobhyB SiobhyB requested review from fluiddot and geriux April 21, 2022 06:03
@SiobhyB SiobhyB marked this pull request as ready for review April 21, 2022 06:03
@geriux
Copy link
Contributor

geriux commented Jun 21, 2022

Hey @SiobhyB 👋 I'm going through my review requests list and I saw this one 😄 I wonder if this perhaps can be closed since the Jetpack reference has been updated in a different PR?

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jun 21, 2022

@geriux, ah, yes, you're right! I'll go ahead to close. :)

@SiobhyB SiobhyB closed this Jun 21, 2022
@fluiddot fluiddot deleted the chore/fix/jetpack-bundle-error branch June 21, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Bug or feature related to Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants