-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses the global store for the post title and adds undo/redo support. #501
Conversation
Fyi, @daniloercoli |
Reassigned to @daniloercoli since he's working on the title feature with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Remember to update the GB hash, once the companion GB PR is refreshed and merged to master
.
@@ -92,7 +91,7 @@ class AppContainer extends React.Component<PropsType, StateType> { | |||
toggleHtmlModeAction={ this.toggleHtmlModeAction } | |||
setTitleAction={ this.setTitleAction } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @diegoreymendez 👋 it looks to me that we can also get rid of passing this.setTitleAction as a prop from component to component. So other components can also use editPost( { title: title } ) via their own props with the help of withDispatch. what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
Following @Tug 's indications here, this PR wires our title to the global store title.
This PR also adds undo/redo support for the title.
Moves forward #372 .
Dependencies:
Gutenberg PR: WordPress/gutenberg#13514
Testing:
Testing edits:
Make sure the title is still as you left it before switching modes.
Testing undo redo:
Make sure undo / redo works as it does in web-Gutenberg (ie: that's our baseline for comparing).