Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 0.69.4 Upgrade - Android #5170

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Sep 23, 2022

Related PRs

Feature branch

Android integration

iOS integration

This PR brings the needed changes to support the new React Native 0.69.4 version.

It only updates the package.json to change the hermesc path to the new location under the React Native folder.

To test, the mobile editor should build and load.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 23, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux force-pushed the rnmobile/upgrade/0.69.4-android branch 3 times, most recently from a0fb2be to f5d4052 Compare October 5, 2022 12:06
@geriux geriux changed the base branch from trunk to rnmobile/upgrade/0.69.4 October 5, 2022 12:06
@geriux geriux mentioned this pull request Oct 5, 2022
2 tasks
@geriux geriux changed the title [Mobile] - React Native 0.69.4 Upgrade - Android React Native 0.69.4 Upgrade - Android Oct 5, 2022
@geriux geriux requested a review from derekblank October 10, 2022 11:00
@geriux geriux added dependencies Pull requests that update a dependency file and removed [Status] In Progress labels Oct 10, 2022
@geriux geriux marked this pull request as ready for review October 10, 2022 11:00
@geriux geriux force-pushed the rnmobile/upgrade/0.69.4-android branch from 2287a81 to c2d4436 Compare October 18, 2022 10:10
@geriux
Copy link
Contributor Author

geriux commented Oct 18, 2022

Hey @derekblank 👋 conflicts are solved now and this is ready for review.

Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll go ahead and merge. 🚀

@derekblank derekblank merged commit a8efc54 into rnmobile/upgrade/0.69.4 Oct 19, 2022
@derekblank derekblank deleted the rnmobile/upgrade/0.69.4-android branch October 19, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants