-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remap font names for iOS for PR 372. #530
Remap font names for iOS for PR 372. #530
Conversation
|
Tests are failing but I've no idea why. Been digging into it without much success so far, so any idea is welcome. |
As discussed with @daniloercoli I'm going to go ahead and merge this into his branch, so I can keep working on making the title work fine for iOS, and he can try to figure out why the tests are failing. |
I think this PR pretty much addressed #419 too. |
Description:
This PR simply remaps some font names for an open PR so that the work for iOS as well.
iOS unfortunately doesn't support font families
serif
andmonospace
.Other changes will be needed but these are the basic changes before implementing the iOS native font properties.
Related PRs:
Target PR: #513
Gutenberg PR: WordPress/gutenberg#13628
Testing:
The only testing needed is to make sure the font are good for Android too.