[Mobile] - Fix regression with the Color hook and ColorPanel #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
force-pushed
the
version-toolkit/gutenberg/rnmobile/fix/color-customization-for-blocks
branch
from
59759c0 to
eaf2810
Compare
added 2 commits
April 19, 2023 18:07
geriux
force-pushed
the
version-toolkit/gutenberg/rnmobile/fix/color-customization-for-blocks
branch
from
89954dd to
05b2fb1
Compare
dcalhoun
approved these changes
Apr 19, 2023
|
The two failing CI tasks appear to be the Columns block slider visual snapshot. I have found this particular test is quite sensitive to the distance the bottom sheet is scrolled. I.e. if it is scrolled too far or too little, it will cause a test failure due to the elements moving slightly. Scroll inertia can also come into play on iOS, where the "bounce" animation may have not yet completed before the snapshot is taken. We may need to merely update the snapshots or the scroll distance may need to be tweaked on each platform. |
geriux
deleted the
version-toolkit/gutenberg/rnmobile/fix/color-customization-for-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.