Release 1.105.0 #6243
Release 1.105.0 #6243
Conversation
bundle/android/strings.xml
Outdated
| <string name="gutenberg_native_take_a_photo" tools:ignore="UnusedResources">Take a Photo</string> | ||
| <string name="gutenberg_native_take_a_photo_or_video" tools:ignore="UnusedResources">Take a Photo or Video</string> | ||
| <string name="gutenberg_native_take_a_video" tools:ignore="UnusedResources">Take a Video</string> |
There was a problem hiding this comment.
#6204 (review), the i18n script is marking these strings as used by the web, so it considers that we don't need to translate them as they would be part of the Gutenberg GlotPress project. However, I checked that these strings are only referenced by native files, hence they won't be translated unless we add them here.
I presume that the fact that these strings are in an extension different from .native.js is making the i18n script consider them as used on the web. Looks like the constants associated with the localized strings are only used in an integration test, not sure if this might confuse the i18n script regarding whether they are used in web or not. In any case, as a workaround, we could simply move the test-only constants to a separate file under the test folder. I'll open a separate PR to address this and prevent this issue in future releases.
There was a problem hiding this comment.
Next releases won't encounter this issue once we merge WordPress/gutenberg#54928.
gutenberg
Outdated
There was a problem hiding this comment.
The Gutenberg reference is not pointing to the latest commit from WordPress/gutenberg#54898. However, I understand that the latest changes in the PR aren't incorporating anything critical that we'd like to check in the CI test jobs.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
# Conflicts: # gutenberg
| <string name="gutenberg_native_take_a_photo" tools:ignore="UnusedResources">Take a Photo</string> | ||
| <string name="gutenberg_native_take_a_photo_or_video" tools:ignore="UnusedResources">Take a Photo or Video</string> |
There was a problem hiding this comment.
Curiously enough, this string is not used anywhere in the Gutenberg codebase 🤔 .
🟢 Writing Flow (iOS)Build: 23.4.0.0 (TestFlight) General
Rich Text Format
Splitting and merging |
🟢 Unsupported Block Tests (iOS)Build: 23.4.0.0 (TestFlight)
|
🟢 Functionality Test Suite 1 (iOS)Build: 23.4.0.0 (TestFlight) Gallery - 1
Gallery - 2
MediaText - 1
MediaText - 2
MultipleUpload - 1
Cover - 1
Editor Theme - 1 |
🟢 New Changes (iOS)Build: 23.4.0.0 (TestFlight) |
🟢 Writing Flow (Android)Build: 23.4-rc-1 General
Rich Text Format
Splitting and merging |
🟢 Unsupported Block Tests (Android)Build: 23.4-rc-1
|
🟢 Functionality Test Suite 5 (Android)Build: 23.4-rc-1 Video block - 1
Video block - 2
File block - 1
File block - 2
File block - 3
Audio block - 1
Audio block - 2
Audio block - 3
Audio block - 4
Synced patterns - 1 Synced patterns - 2 Embed block - 1
Embed block - 2
|
🟢 New Changes (Android)Build: 23.4-rc-1 |
Release for Gutenberg Mobile 1.105.0
Related PRs
Extra PRs that Landed After the Release Was Cut
No extra PRs yet. 🎉
Changes
Change 1: Prevent crash from invalid media URLs
Change 2: Limit inner blocks nesting depth to avoid call stack size exceeded crash
Change 3: Fallback to Twitter provider when embedding X URLs
Test plan
Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.
Release Submission Checklist
RELEASE-NOTES.txtis updated with all the changes that made it to the release. ReplaceUnreleasedsection with the release version and create a newUnreleasedsection.gutenberg/packages/react-native-editor/CHANGELOG.mdis updated with all the changes that made it to the release. Replace## Unreleasedwith the release version and create a new## Unreleased.