Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve E2E test consistency #6313

Merged
merged 2 commits into from
Oct 24, 2023
Merged

test: Improve E2E test consistency #6313

merged 2 commits into from
Oct 24, 2023

Conversation

dcalhoun
Copy link
Member

Avoid setup scripts during test runs to mirror changes in
WordPress/gutenberg#55554.

To test:

  • Verify the npm run core test:e2e:setup command succeeds when run.
  • Verify the npm run test:e2e:ios:local command does not throw errors.
  • Verify the npm run test:e2e:android:local command does not throw errors.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun
test: Avoid setup scripts during test runs
928a3cf 
There may be clarity and efficiency by having an explicit setup script.
It was avoid running unnecessary scripts during test runs. It is also
referenced in the current documentation as a script to run
intentionally.
@dcalhoun dcalhoun added the Testing Anything related to automated tests label Oct 23, 2023
@dcalhoun dcalhoun marked this pull request as ready for review October 23, 2023 20:10
@dcalhoun dcalhoun requested a review from geriux October 23, 2023 20:10
@dcalhoun dcalhoun force-pushed the test/improve-e2e-test-consistency branch from aa22694 to 185c24c Compare October 23, 2023 23:50
geriux
geriux approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI check that failed is related to a flaky test and not because of these changes 🚀

@dcalhoun dcalhoun merged commit 1a47527 into version-toolkit/gutenberg/rnmobile/appium-2 Oct 24, 2023
@dcalhoun dcalhoun deleted the test/improve-e2e-test-consistency branch October 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @geriux