Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gallery Block V1 and other experimental flags #6973

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jul 9, 2024

Related PRs:

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux marked this pull request as ready for review July 9, 2024 15:40
@geriux geriux requested a review from dcalhoun July 9, 2024 15:54
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gallery block appears to function as expected. 👍🏻

I noted oddities on both iOS and Android that appear unrelated to these changes. Do you encounter these as well?

When appending an image to a Gallery block, it will also show an If uploading to a gallery all files need to be image formats error toast. If the appended image already exists in the Gallery, the image will not be added. However, using the block inserter while focused upon a Gallery item, the image is added successfully. At times, the order of Gallery items is also unexpectedly shuffled.

This appears to be occurring as far back as release 24.6.

Error toast message

gallery-addition-error

Screen recording
RPReplay_Final1720554628.MP4

Steps to Reproduce:

  1. Insert a Gallery block.
  2. Select media for the block.
  3. Move block selection to the Gallery block.
  4. Tap the inline appender.
  5. Add media already within the Gallery block.
  6. Note the error message and lack of new image.
  7. Move block selection to an Image block within the Gallery block.
  8. Tap the block inserter in the toolbar.
  9. Add media already within the Gallery block.
  10. Note the image is added.
  11. Move block selection to the Gallery block.
  12. Tap the inline appender.
  13. Add media already within the Gallery block.
  14. Note the error message, the lack of new image, and the existing images order is reshuffled.

@geriux
Copy link
Contributor Author

geriux commented Jul 10, 2024

When appending an image to a Gallery block, it will also show an If uploading to a gallery all files need to be image formats error toast.

I did notice that one, I forgot to mention it in the PR 😅 I was planning to work on that next.

If the appended image already exists in the Gallery, the image will not be added. However, using the block inserter while focused upon a Gallery item, the image is added successfully. At times, the order of Gallery items is also unexpectedly shuffled.

Oh wow, this I did not notice, it seems a bit broken 🥲 I'll take a look so we can ship a fix for at least some of the issues. Thanks for the review and testing!

@geriux
Copy link
Contributor Author

geriux commented Jul 11, 2024

I'm working on the issues above in WordPress/gutenberg#63426 I'll merge this PR and open a new one for the other fix.

@geriux geriux merged commit 31c63ce into trunk Jul 11, 2024
20 checks passed
@geriux geriux deleted the remove/experimental-flags-gallery-v1 branch July 11, 2024 12:49
@geriux geriux mentioned this pull request Jul 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants