Update to latest GB master #80

hypest · 2018-07-26T12:12:49Z

Update to the currently latest Gutenberg master branch.

Changes:

Using the @wordpress/blocks packages now, and directly from src
For some reason, Flow doesn't like pointing to the root of the blocks
package (while it's not complaining for the same reason for the
element package). Having the flow config pointing inside the src dir
of the package now.
Need to expose window.Node for a couple of its constants. Using
jsdom's definitions for that.
Code block needs a css class defined (wp-block-code) in the innerHTML
for validation to succeed

* using the @wordpress/blocks packages now, and directly from src * For some reason, Flow doesn't like pointing to the root of the blocks package (while it's not complaining for the same reason for the `element` package). Having the flow config pointing inside the `src` dir of the package now. * Need to expose `window.Node` for a couple of its constants. Using jsdom's definitions for that. * Code block needs a css class defined (wp-block-code) in the innerHTML for validation to succeed

mzorz

Thanks for sharing this @hypest! - questions / comments below. I'd approve then 👍

mzorz · 2018-07-26T12:49:50Z

.flowconfig

@@ -85,6 +85,7 @@ munge_underscores=true

 module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'
 module.name_mapper='@gutenberg' -> '<PROJECT_ROOT>/gutenberg'
+module.name_mapper='@wordpress/blocks' -> '<PROJECT_ROOT>/gutenberg/packages/blocks/src'


I'm actually not sure we should name this @wordpress as blocks are actually @gutenberg's. As a result of this observation we may also consider how other mappers are called, which I'm not sure of, but for Gutenberg blocks it sounds like it's definitely @gutenberg, wdyt?

Also, may I ask why do we set this here in Flow, and is not set in the module mapper plugin in .babelrc to indicate an alias? That's how I'd approached it, and would like to learn if that's a feasible path or not, and why this would be preferred, if the question first of all makes sense (i.e. can Flow be used for the same thing?)

I'm actually not sure we should name this @WordPress as blocks are actually @gutenberg's.

The package is actually called like that (see its package definition here) so, it makes sense to keep its original name.

why do we set this here in Flow, and is not set in the module mapper plugin in .babelrc to indicate an alias

It's not an alias as far as the build pipeline is concerned. For Metro, @wordpress/blocks is a normal package and tries its best to resolve it. Metro being the smart tool it is, it actually discovers the package automagically inside the gutenberg/packages folder.

We gradually have moved away from having to define aliases in Babel as the Gutenberg code has been npm-package-ized more and more. Previously, we had to "mock" those packages to mimic what Webpack is doing on the Gutenberg build side. But nowadays, the published Gutenberg packages can be easily picked up by Metro without alias tricks. Some packages (namely, the editor package` is still not published to NPM and that's why it's practically the only alias we have left in Babel.

But, Flow is not as smart as Metro. We need to give more direct instructions to Flow to go find the packages.

While on the subject, Jest (our testing tool) is also not as smart as Metro and that's why we have similar aliases in its jest.config.js file.

The package is actually called like that (see its package definition here) so, it makes sense to keep its original name.

👍 thanks for pointing to the original definition

Thanks for the detailed explanation about moving away from module resolver. I wonder why that wouldn't work then off the shelve for me (automagically as you say) when working on a similar PR in https://github.com/wordpress-mobile/gutenberg-mobile/tree/update/use-latest-gb-master

While on the subject, Jest (our testing tool) is also not as smart as Metro and that's why we have similar aliases in its jest.config.js file

Thanks for pointing this out as well, brings useful insight

mzorz · 2018-07-26T12:51:34Z

package.json

@@ -8,6 +8,7 @@
  },
  "devDependencies": {
    "@wordpress/babel-preset-default": "^1.1.2",
+    "@wordpress/block-serialization-spec-parser": "^1.0.0",


I couldn't realize this was needed. May I ask, even if it's a trivial question, how you come to know this needs to be set as a dependency?

Ah, that crops up when you try to run the tests actually. If you try without the dep you'll notice Jest complaining. Haven't investigated why it happens only on the testing pipeline though.

mzorz · 2018-07-26T12:52:23Z

package.json

@@ -61,6 +62,7 @@
  },
  "dependencies": {
    "@wordpress/autop": "^1.0.6",
+    "@wordpress/compose": "^1.0.1",


why is this included as a dependency here, but then is denylisted here?

OK, so, Metro being the smart tool it is, it actually tries to resolve the packages by looking in the local filesystem. So, when you do want to use the remote package from NPM you need to denylist the local package dir.

mzorz · 2018-07-26T12:58:56Z

src/globals.js

@@ -18,3 +19,7 @@ doc.implementation.createHTMLDocument = function( html ) {

 // `hpq` depends on `document` be available globally
 global.document = doc;
+
+if ( ! global.window.Node ) {


Ah! question, does defining this in this way fix the red screen I got saying undefined is not an object (evaluating '_window$Node.TEXT_NODE')?

Yes! So, turns out that recent Gutenberg changes exposed the need for those constants from window.Node that were previously handled from dom-react and our jsdom-core dep. But yeah, with the changes we apparently need to manually add the support.

excellent, thanks for this clarification!

mzorz

Okay, thanks for thoroughly answering (as usual) my questions @hypest . I'll now test the PR and approve if all good 👍

mzorz

tested, LGTM

…pport arbirtary focus codes from RN (#81)

Ability to build a binary via jitpack

hypest requested a review from mzorz July 26, 2018 12:12

mzorz reviewed Jul 26, 2018

View reviewed changes

daniloercoli mentioned this pull request Jul 26, 2018

Introduce paragraph block and RichText component for mobile #81

Merged

mzorz reviewed Jul 26, 2018

View reviewed changes

mzorz approved these changes Jul 26, 2018

View reviewed changes

mzorz merged commit 6e85b04 into master Jul 26, 2018

mzorz deleted the feature/upgrade-gb-master-26-jul-2018 branch July 26, 2018 16:18

mzorz added a commit that referenced this pull request Nov 28, 2018

updated react-native-aztec hash to include jitpack support (#80) + su…

f79eff6

…pport arbirtary focus codes from RN (#81)

mzorz mentioned this pull request Nov 28, 2018

Bump Aztec wrapper hash #285

Merged

hypest pushed a commit that referenced this pull request Jan 3, 2019

Merge pull request #80 from wordpress-mobile/try/android-aar

3cecb4a

Ability to build a binary via jitpack

hypest mentioned this pull request Apr 9, 2019

Pasting external content - known issues #624

Open

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to latest GB master #80

Update to latest GB master #80

hypest commented Jul 26, 2018

mzorz left a comment

mzorz Jul 26, 2018

hypest Jul 26, 2018

mzorz Jul 26, 2018 •

edited

Loading

mzorz Jul 26, 2018

mzorz Jul 26, 2018

mzorz Jul 26, 2018

hypest Jul 26, 2018

mzorz Jul 26, 2018 •

edited by hypest

Loading

hypest Jul 26, 2018 •

edited

Loading

mzorz Jul 26, 2018

hypest Jul 26, 2018

mzorz Jul 26, 2018

mzorz left a comment

mzorz left a comment

Update to latest GB master #80

Update to latest GB master #80

Conversation

hypest commented Jul 26, 2018

mzorz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mzorz Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mzorz Jul 26, 2018 • edited by hypest Loading

Choose a reason for hiding this comment

hypest Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mzorz left a comment

Choose a reason for hiding this comment

mzorz left a comment

Choose a reason for hiding this comment

mzorz Jul 26, 2018 •

edited

Loading

mzorz Jul 26, 2018 •

edited by hypest

Loading

hypest Jul 26, 2018 •

edited

Loading