Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to clarify functions in jsdom-patches file. #826

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Apr 5, 2019

This PR aims to address (and clarify) the functions added to the jsdom-patches.js file, imported in globals.js. No code is modified by these commits (only comments).

Please let me know if any further clarifications would be useful.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 5, 2019

Warnings
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

@mkevins mkevins added this to the v1.2 milestone Apr 5, 2019
@hypest hypest modified the milestones: v1.2, v1.3 Apr 5, 2019
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest merged commit 061e052 into develop Apr 9, 2019
@hypest hypest deleted the update/add-comments-to-clarify-jsdom-patches branch April 9, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants