Improving accessibility on Post Title #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
etoledom
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
On iOS it works as expected! ✨
The Android side has two issues:
-
The Screen Reader automatically focus the Text Field without reading the block's accessibility label. The focus action should happen only after double tapping on the element (PostTitle in this case).
-
Having a Paragraph block selected, it doesn’t lose its selection when the Title Field get focus.
This one will probably be fixed after fixing (1.)
After some investigation with @pinarol, we arrive to the conclusion that this issue is external to this PR and should be addressed separately: #918
So let's 
Great work @pinarol ! 🎉
daniloercoli
added a commit
that referenced
this pull request
Apr 23, 2019
…rg-mobile into issue/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Improving accessibility on Post Title (#916) Point to GB master without the list block suppression Update JS bundles Update Gutenberg hash with lint error fixes Update JS bundles Suppress the List block on Android Updated JS bundles with title focus fix Update JS bundles for 1.3.0 Update version to 1.3.0 Update AztecEditor-iOS to 1.6.0 Update gutenberg ref to latest master Update gutenberg ref Update gutenberg ref # Conflicts: # gutenberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912
Changes reside in gutenberg PR: WordPress/gutenberg#15106
This PR improves accessibility (screen reader) for the Post Title. In particular when it's not focused.
Empty title:
Label: "Post title. Empty"
Title with a text:
Label: "Post title. [the text]"
When caret is blinking on Post Title the accessibility behavior is handed over to the OS and the system decides how to handle the accessibility for the text input field.
To test (iOS):
Activate VoiceOver: https://github.com/wordpress-mobile/WordPress-iOS/wiki/Using-VoiceOver
To test (Android):
Activate TalkBack: https://www.wikihow.com/Enable-TalkBack-on-Your-Android
In my case, the system had a handy tutorial on how to use it.
If your version doesn't have it, it's actually very similar to VoiceOver.
Test Steps
Tap on the title when it is empty
It should say: "Post title. Empty"
Double tap to enter some text and focus to another text input
Tap on the title again
It should say: "Post title. [entered text]"
A note on Android
On Android I could only be able to hear "Post title. Empty" when I tap the area out of the text input. It looks like childs continue to be accessible and I am not sure this is sth that can be resolved.