Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Handle the iOS z-gesture to exit modals and block selection #926

Merged
merged 18 commits into from
May 23, 2019
Merged

Accessibility: Handle the iOS z-gesture to exit modals and block selection #926

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8ed04b6
Handle iOS z-gesture for block list and modals
Tug Apr 24, 2019
e3055eb
Merge remote-tracking branch 'origin/develop' into update/accessibili…
Tug Apr 26, 2019
6d9b81f
Update gutenberg ref
etoledom May 10, 2019
a1b3437
Merge branch 'develop' into update/accessibility-ios-z-gesture
etoledom May 10, 2019
675f91d
Update gutenberg ref
etoledom May 10, 2019
3e04dcb
Update gutenberg ref
etoledom May 14, 2019
a200d20
Merge branch 'develop' into update/accessibility-ios-z-gesture
etoledom May 14, 2019
1bfe7ac
Update gutenberg ref
etoledom May 14, 2019
52608cd
Update gutenberg ref
etoledom May 15, 2019
9f21dbc
Merge branch 'develop' into update/accessibility-ios-z-gesture
etoledom May 15, 2019
d691aa0
Update gutenberg ref
etoledom May 16, 2019
62117a1
Merge branch 'develop' into update/accessibility-ios-z-gesture
etoledom May 16, 2019
39db1c2
Update gutenberg ref
etoledom May 21, 2019
47abf1c
Merge branch 'develop' into update/accessibility-ios-z-gesture
etoledom May 21, 2019
906d87c
Update gutenberg ref
etoledom May 21, 2019
31d16f3
Roll back changes on .vscode/settings.json
etoledom May 21, 2019
efd844c
Merge remote-tracking branch 'origin/develop' into update/accessibili…
Tug May 23, 2019
4f76ab9
Update gutenberg ref
Tug May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@

// Use 'prettier-eslint' instead of 'prettier'. Other settings will only be fallbacks in case they could not be inferred from eslint rules.
"prettier.eslintIntegration": true,
"editor.insertSpaces": false,
etoledom marked this conversation as resolved.
Show resolved Hide resolved
}
2 changes: 1 addition & 1 deletion gutenberg
Open in desktop
Submodule gutenberg updated 3 files
+3 −10 bin/install-wordpress.sh
+1 −0 packages/block-editor/src/components/mobile/bottom-sheet/index.native.js
+32 −27 packages/block-library/src/image/edit.native.js
9 changes: 8 additions & 1 deletion src/block-management/block-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ type PropsType = {
rootClientId: ?string,
blockClientIds: Array<string>,
blockCount: number,
clearSelectedBlock: () => void,
focusBlock: ( clientId: string ) => void,
selectBlock: ( clientId: string ) => void,
insertBlock: ( block: BlockType, position: number ) => void,
replaceBlock: ( string, BlockType ) => mixed,
Expand Down Expand Up @@ -253,7 +255,10 @@ export class BlockManager extends React.Component<PropsType, StateType> {

renderList() {
return (
<View style={ { flex: 1 } } >
<View
style={ { flex: 1 } }
onAccessibilityEscape={ this.props.clearSelectedBlock }
>
<KeyboardAwareFlatList
{ ...( Platform.OS === 'android' ? { removeClippedSubviews: false } : {} ) } // Disable clipping on Android to fix focus losing. See https://github.com/wordpress-mobile/gutenberg-mobile/pull/741#issuecomment-472746541
accessibilityLabel="block-list"
Expand Down Expand Up @@ -381,9 +386,11 @@ export default compose( [
insertBlock,
replaceBlock,
selectBlock,
clearSelectedBlock,
} = dispatch( 'core/block-editor' );

return {
clearSelectedBlock,
insertBlock,
selectBlock,
replaceBlock,
Expand Down