Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for running simulator with other iOS devices to README #944

Merged

Conversation

iamthomasbishop
Copy link
Contributor

This PR adds simple instructions to the README doc for running the iOS simulator with other devices.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 30, 2019

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@iamthomasbishop iamthomasbishop marked this pull request as ready for review May 3, 2019 18:12
@iamthomasbishop iamthomasbishop requested a review from etoledom May 3, 2019 18:13
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @iamthomasbishop !

I added a couple of small comments, nothing really important though.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- Specify device _simulators_
- Remove bit about opening target device in Simulator prior to running `yarn ios`
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉
Thank you for the update 😁

@iamthomasbishop iamthomasbishop merged commit 25f671f into develop May 6, 2019
@hypest hypest deleted the update/add-ios-simulator-device-instructions branch May 7, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants