Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #843
Maybe this one too: wordpress-mobile/WordPress-iOS#11583
This PR fixes an issue where the editor enters on a onFocus/onBlur infinite loop. This was easily reproduced by selecting text on a paragraph block, and moving it inside the same block.
I tracked the issue until this line:
gutenberg-mobile/react-native-aztec/src/AztecView.js
Line 149 in 6513ba8
But we need it in order to let Gutenberg know that the TextView was focused by iOS. Needed to solve this issue: #702
With some investigation I noticed that
textViewDidBeginEditing
was sending one extraonFocus
event that is not needed, and that triggered the loop. It was solved by sending theonFocus
frombecomeFirstResponder
, with the proper checks.To test: