-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich Image Caption feature branch #975
Conversation
Add Image Caption Styling
Leaving merge conflict to be resolved manually
Add text alignment prop for centering image captions
Updated this PR and WordPress/gutenberg#15571 to incorporate the changes from the video block. I would appreciate a couple of 👀 from @mchowning and @marecar3 or @pinarol to be sure that everything is in order, since there were a few conflicts to be resolved on Thank you! |
Hey, @etoledom @mchowning this PR looks good :) However, there is some case where it crashes. So if you try to upload the video, it will crash with red screen. The issue is in this line of code: https://github.com/WordPress/gutenberg/blob/449c25459c917b546cdfd786dbfd56dd3cb9a43a/packages/block-library/src/video/edit.native.js#L218 Having that on mind we probably want to remove and maybe to move this :
into the corresponding video style file: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/video/style.native.scss |
Nice catch @marecar3 ! A better "fix" will be when we use RichText Captions in Video Blocks too (in the future). Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @etoledom! @mchowning! :)
LGTM!
Thank you all, and congrats @mchowning ! |
This PR merges the Rich Image Caption feature branch.
All this code has been already tested and approved here: #941
A smoke test should be enough to ✅ this PR.
For more detailed test cases, please check out #941
gutenberg
side PR: WordPress/gutenberg#15571cc @mchowning