Use Sodium for secret encryption and decryption #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #128 +/- ##
===========================================
- Coverage 45.04% 44.64% -0.41%
===========================================
Files 81 81
Lines 3563 3537 -26
===========================================
- Hits 1605 1579 -26
Misses 1958 1958
Continue to review full report at Codecov.
|
Fixes an openSSL warning:
```
openssl aes-256-cbc -md sha256 -d -in .circleci/.firebase.secrets.json.enc -out .circleci/.firebase.secrets.json -k “${FIREBASE_SECRETS_ENCRYPTION_KEY}”
*** WARNING : deprecated key derivation used.
Using -iter or -pbkdf2 would be better.
```
Also gets us out of manual crypto.
This is a breaking change and should be carefully merged to avoid breaking projects.
jkmassel
force-pushed
the
use/sodium-for-secret-encryption
branch
from
991d4a0 to
9bab7ae
Compare
loremattei
suggested changes
Jun 23, 2020
There was a problem hiding this comment.
@jkmassel should we add a check to verify that libsodium is installed? It looks like it fails with an impossible to understand error if it's not 😅
Also, I tested bundle exec fastlane run configure_update on a test branch forked out the current WPiOS develop and I get this error when it tries to re_apply:
RbNaCl::LengthError: [!] Nonce was 25 bytes (Expected 24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an openSSL warning:
Also gets us out of manual crypto, but the tradeoff is an additional homebrew dependency. IMHO this isn't a huge deal given the existence of wordpress-mobile/WordPress-iOS#14100, but we should wait to merge this in until the
libsodiumdependency can be added to that script.This is a breaking change and should be carefully merged to avoid breaking projects.
To Test