[Cleanup/rubocop] 6 #217
Merged
[Cleanup/rubocop] 6 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
approved these changes
Feb 25, 2021
lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb
Outdated
Show resolved
Hide resolved
lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb
Outdated
Show resolved
Hide resolved
lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_download_action.rb
Outdated
Show resolved
Hide resolved
lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_translators_strings.rb
Outdated
Show resolved
Hide resolved
lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_translators_strings.rb
Outdated
Show resolved
Hide resolved
mokagio
reviewed
Feb 25, 2021
Comment on lines
+32
to
+33
| Style/AsciiComments: | ||
| Enabled: false |
There was a problem hiding this comment.
I'm happy with this but I'm curious about the rationale?
There was a problem hiding this comment.
Generally, I'd like to have a rationale for every disabled rule or any other variation from the default.
There was a problem hiding this comment.
My rationale is:
- We already use some Unicode characters in existing comments, like em dash — which I'm a big fan of, I have to admit — and ellipsis… which I use here and there too.
- It feels reasonable to consider that at some point we might also want to use emojis, as well as some Unicode characters necessary to draw nicer Monodraw graphs — and you know how I love those too 😛.
- And in the era of Unicode I don't see any reason why we shouldn't allow them. (iow, I don't really see the rationale for the default value of this rule.)
I'll add a comment to explain that rationale in the config file anyway indeed.
TL;DR:
There was a problem hiding this comment.
Rationale added as comment in 70fb5d5
Co-authored-by: Gio Lodi <giovanni.lodi42@gmail.com>
mokagio
reviewed
Feb 26, 2021
| Style/EmptyMethod: | ||
| EnforcedStyle: expanded | ||
|
|
||
| # Trailing commas in array literals helps having smaller diffs when we want to add additional parameters |
There was a problem hiding this comment.
👍
Totally out of topic and not really a Ruby friendly thing, but I do love how Elm does trailing commas
[ "this"
, "makes"
, "for"
, "clear"
, "diffs"
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick additional round of fixes.
Note that I think I'll stop doing rubocop after that to focus on #203 and other improvements