Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share GlotPress 429 auto retry from ASC metadata to iOS strings download #516

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from
Open

Share GlotPress 429 auto retry from ASC metadata to iOS strings download #516

wants to merge 22 commits into from

Commits on Oct 3, 2023

  1. Implement a prototype version of 429-auto-retry for iOS strings

    @mokagio
    mokagio committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    010074e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Use Ruby 3.2.2

    @mokagio
    mokagio committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6bac21d View commit details
    Browse the repository at this point in the history

  2. Use latest WebMock, 3.19.1 

    I thought this might help with an issue I'm experiencing where there the
uri of a stubbed response is unexpectedly nil, but it did not.
    @mokagio
    mokagio committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5d1b52a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Add WebMock monkey-patch to work around nil uri in response 

    See bblimke/webmock#469
    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f088131 View commit details
    Browse the repository at this point in the history

  2. Add test for current metadata_download_helper behavior

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6326cf7 View commit details
    Browse the repository at this point in the history

  3. Extract retry logic in GlotPressDownloader helper

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ee2bb8b View commit details
    Browse the repository at this point in the history

  4. Remove useless parameters from extracted GlotPressDownloader

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fe9a93b View commit details
    Browse the repository at this point in the history

  5. Add test for GlotPressDownaloader

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    aa6bf79 View commit details
    Browse the repository at this point in the history

  6. Move GlotpressDownloader tests in dedicated file

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    975dc46 View commit details
    Browse the repository at this point in the history

  7. Use label for auto_retry GlotpressDownloader init parameter

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ed269cf View commit details
    Browse the repository at this point in the history

  8. Make sleep time and retries configurable in GlotpressDownloader

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    0c1b71b View commit details
    Browse the repository at this point in the history

  9. Add test for max retries and refine the implementation

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cd87e7b View commit details
    Browse the repository at this point in the history

  10. Add test for GlotPress 429 with manual retry

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8433810 View commit details
    Browse the repository at this point in the history

  11. Add test for 200 behavior in GlotPress download

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7f3ccb5 View commit details
    Browse the repository at this point in the history

  12. Make sleep time configurable in MetadataDownloader 

    This way, the tests can run fast, instead of waiting for the default 20s
    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cd5ef51 View commit details
    Browse the repository at this point in the history

  13. Move GlotpressDownaloder in dedicated file

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d35d027 View commit details
    Browse the repository at this point in the history

  14. Use new GlotpressDownloader in ios_l10n_helper

    @mokagio
    mokagio committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    80ddf81 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Add missing options in recursive GlotpressDownloader call

    @mokagio
    mokagio authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    71077a8 View commit details
    Browse the repository at this point in the history

  2. Remove an unused autoretry_count parameter

    @mokagio
    mokagio authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    48896c8 View commit details
    Browse the repository at this point in the history

  3. Remove an unused auto_retry_max_attempts parameter

    @mokagio
    mokagio authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0330b3b View commit details
    Browse the repository at this point in the history

  4. Add test for metadata downloader file saving behavior 

    While I was at it... Also useful to ensure the new downloader object
didn't break the existing download logic.
    @mokagio
    mokagio committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0847fc9 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry for new 429 auto retry behavior

    @mokagio
    mokagio committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    65801ac View commit details
    Browse the repository at this point in the history