Test order of blocks in inserter #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
reviewed
Aug 17, 2021
There was a problem hiding this comment.
I'd also include this test case in the README file where we hold the index.
If this should be checked as part of the full testing we do when cutting a release, probably we should consider referencing it somewhere else too 🤔 , wdyt?
twstokes
reviewed
Aug 17, 2021
👍 Done! |
fluiddot
reviewed
Aug 17, 2021
twstokes
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure where is the best place to put this test to ensure it gets regularly run. Definitely open to other suggestions.
If you think there is a better way we could automate checking this relatively easily, let me know.