Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/wrong geometries #105

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Bug/wrong geometries #105

merged 6 commits into from
Dec 17, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Add unit tests that reproduce the issue
  • Add order by clause in SQL command that generates summaries

How to test it

Other notes

@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 12, 2024 18:36 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

PR Deployment Details:
🚀 PR deployed to https://w7tfg3g781.execute-api.us-east-1.amazonaws.com/

@zacdezgeo zacdezgeo marked this pull request as ready for review December 12, 2024 18:42
@zacdezgeo
Copy link
Collaborator Author

zacdezgeo commented Dec 12, 2024 •
edited
Loading

@andresfchamorro; Solved our issue in #104 !
image

@zacdezgeo zacdezgeo requested a review from alukach December 12, 2024 18:44
@zacdezgeo zacdezgeo self-assigned this Dec 12, 2024
@zacdezgeo zacdezgeo added the bug Something isn't working label Dec 12, 2024
@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 12, 2024 19:03 — with GitHub Actions Inactive
@zacdezgeo zacdezgeo merged commit dfd9c9b into main Dec 17, 2024
3 checks passed
@zacdezgeo zacdezgeo deleted the bug/wrong-geometries branch December 17, 2024 15:20
@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 17, 2024 15:20 — with GitHub Actions Inactive
@zacdezgeo zacdezgeo temporarily deployed to Space2Stats API Dev December 17, 2024 15:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach Awaiting requested review from alukach

Assignees

@zacdezgeo zacdezgeo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API returns wrong geometries
1 participant
@zacdezgeo