Refactor deployment tooling #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
had a problem deploying
to
Space2Stats API Dev
GitHub Actions
Failure
alukach
had a problem deploying
to
Space2Stats API Dev
GitHub Actions
Failure
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
|
PR Deployment Details: |
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
temporarily deployed
to
Space2Stats API Dev
GitHub Actions
Inactive
alukach
had a problem deploying
to
Space2Stats API Dev
GitHub Actions
Error
ciaransweet
reviewed
Nov 6, 2024
| destroy-pr-preview: | ||
| if: ${{ github.event.action == 'closed' }} | ||
| uses: "./.github/workflows/deploy.yml" |
There was a problem hiding this comment.
Should this not be calling destroy?
alukach
added a commit
that referenced
this pull request
Nov 7, 2024
* Update adding staging mechanism * Add CD pipeline * Solve f-string matching * Update event to push on main * Add dev CD * Remove npm and node specific jobs * Update variables * Update environment * Update role * Remove cdk bootstrap * Add working directory for cdk deployment * Add cdk requirements * Update cdk requirements * Update deployment variables * Refactor deployment tooling (#85) * Migrate to reusable workflow * Add tooling for PR preview URL * Add runs-on * Pre-commit * Refactor triggers * Bump version * Add permissions * Fix working dir * Fix URL output * Fix comment find * Add tooling to tear down PR preview * Fix commenting * Fix * Run tests on all pushes * Refactor * Fix * Expand events * Fix destroy * Prevent unnecessary deployments * Pass in PR number * Prevent testing on closed PRs * Refactor * Mv to workflows * Fix destroy * Rework trigger * Refine * Rm old needs * Rework trigger * Try fix if condition * Mv deployment trigger back to ci.yml * Rework triggers * Rename jobs * Set concurrency to stage * Only trigger on pushes to main --------- Co-authored-by: Anthony Lukach <anthonylukach@gmail.com>
Gabe-Levin
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Update adding staging mechanism * Add CD pipeline * Solve f-string matching * Update event to push on main * Add dev CD * Remove npm and node specific jobs * Update variables * Update environment * Update role * Remove cdk bootstrap * Add working directory for cdk deployment * Add cdk requirements * Update cdk requirements * Update deployment variables * Refactor deployment tooling (#85) * Migrate to reusable workflow * Add tooling for PR preview URL * Add runs-on * Pre-commit * Refactor triggers * Bump version * Add permissions * Fix working dir * Fix URL output * Fix comment find * Add tooling to tear down PR preview * Fix commenting * Fix * Run tests on all pushes * Refactor * Fix * Expand events * Fix destroy * Prevent unnecessary deployments * Pass in PR number * Prevent testing on closed PRs * Refactor * Mv to workflows * Fix destroy * Rework trigger * Refine * Rm old needs * Rework trigger * Try fix if condition * Mv deployment trigger back to ci.yml * Rework triggers * Rename jobs * Set concurrency to stage * Only trigger on pushes to main --------- Co-authored-by: Anthony Lukach <anthonylukach@gmail.com>
Gabe-Levin
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Update adding staging mechanism * Add CD pipeline * Solve f-string matching * Update event to push on main * Add dev CD * Remove npm and node specific jobs * Update variables * Update environment * Update role * Remove cdk bootstrap * Add working directory for cdk deployment * Add cdk requirements * Update cdk requirements * Update deployment variables * Refactor deployment tooling (#85) * Migrate to reusable workflow * Add tooling for PR preview URL * Add runs-on * Pre-commit * Refactor triggers * Bump version * Add permissions * Fix working dir * Fix URL output * Fix comment find * Add tooling to tear down PR preview * Fix commenting * Fix * Run tests on all pushes * Refactor * Fix * Expand events * Fix destroy * Prevent unnecessary deployments * Pass in PR number * Prevent testing on closed PRs * Refactor * Mv to workflows * Fix destroy * Rework trigger * Refine * Rm old needs * Rework trigger * Try fix if condition * Mv deployment trigger back to ci.yml * Rework triggers * Rename jobs * Set concurrency to stage * Only trigger on pushes to main --------- Co-authored-by: Anthony Lukach <anthonylukach@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the CICD pipeline to deploy a preview environment whenever a PR is created.
URL to API Gateway is added via comment to PR (see below).
Preview environment should be deleted when PR is closed/merged, but this is hard to test until we merge to
main.