Node/Processor: Peg observation metric for us #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
node_processor_peg_obsv_metric_for_us
branch
from
5532c26
to
8997a04
Compare
evan-gray
reviewed
Aug 30, 2024
panoel
previously approved these changes
Aug 30, 2024
bruce-riley
force-pushed
the
node_processor_peg_obsv_metric_for_us
branch
from
8997a04
to
d6481ca
Compare
bingyuyap
approved these changes
Aug 30, 2024
panoel
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactoring of the processor included a change to not do all of the
handleObservationprocessing on our own observations. This avoids unnecessary work, but the change also caused us to stop peggingwormhole_observations_signed_by_guardian_total, which at least one guardian does not like. This PR make it peg that metric for our own observations.