Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Native document reference support! #238

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wovalle
Copy link
Owner

@wovalle wovalle commented Feb 28, 2021

Closes #118

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #238 (b6c88f7) into master (b66b24e) will decrease coverage by 0.20%.
The diff coverage is 94.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   94.85%   94.64%   -0.21%     
==========================================
  Files          24       25       +1     
  Lines         583      691     +108     
  Branches       95      128      +33     
==========================================
+ Hits          553      654     +101     
- Misses         27       34       +7     
  Partials        3        3              
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/Errors/index.ts 71.42% <66.66%> (-3.58%) ⬇️
src/TypeGuards.ts 92.85% <83.33%> (-7.15%) ⬇️
src/utils.ts 97.22% <92.85%> (-2.78%) ⬇️
src/BaseFirestoreRepository.ts 98.46% <93.33%> (-1.54%) ⬇️
src/AbstractFirestoreRepository.ts 91.34% <100.00%> (+0.72%) ⬆️
src/Batch/FirestoreBatchUnit.ts 88.13% <100.00%> (-1.87%) ⬇️
src/Decorators/DocumentReference.ts 100.00% <100.00%> (ø)
src/Decorators/index.ts 100.00% <100.00%> (ø)
src/MetadataStorage.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66b24e...b6c88f7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to create a new document with a reference?
1 participant