Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blank space when trimming the version #130

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

marksabbath
Copy link
Contributor

The verify-checksum command relies on the method find_var to get the WordPress version to check against. The version currently comes with an extra space which causes an additional character when performing the HTTP request to https://api.wordpress.org/core/checksums/1.0/.

Example HTTP request performed by verify-checksums:

https://api.wordpress.org/core/checksums/1.0/?version=%206.2.2

How it should look like:

https://api.wordpress.org/core/checksums/1.0/?version=6.2.2

Hope this saves some striping in the server.

@marksabbath marksabbath requested a review from a team as a code owner October 1, 2024 21:25
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@swissspidy swissspidy added this to the 2.3.0 milestone Oct 1, 2024
@swissspidy swissspidy merged commit bc82cfb into wp-cli:main Oct 1, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants