Fix: correctly deactivate network activated plugin before uninstall. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow deleting the currently active theme
…tion Handle extension activation for WP error or extension not found
…-alert Display warning in plugin list info if plugin version is higher than expected
Move PHP 5.4 tests from `WP_VERSION` `latest` to `5.1`
Fix the wp-cli#166 bug: the "wp theme search" command has not the "page" option
Enhancement: Add PHP 7.3 to Travis CI build matrix
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
Allow Composer plugins to run
Ensure bundled themes don't interfere with update tests
…add/mu-plugin-title
…command into add/mu-plugin-title
When uninstalling a network activated plugin, the network tag is now added to correctly deactivate the plugin before removal.
NielsdeBlaauw
changed the title
|
@NielsdeBlaauw thank you for your contribution! It looks good to me, however the functional tests are failing. Can you please look into it? |
|
@Sidsector9 thanks, I've updated the changeset to fix the output for results reporting. Cheers. |
|
The code looks good. It should have a test to cover this specific usage with a multisite. If you need help give a shout. |
|
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/f9aa4f759c7d57ff2663d07766241692 in case this PR is auto-closed or broken in some way. |
danielbachhuber
force-pushed
the
master
branch
from
98fbf53
to
a07cad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uninstalling a network activated plugin, the network tag is now added to correctly deactivate the plugin before removal.
Fixes #312