-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title/description for mu-plugins. #305
Conversation
Thanks for the PR, @alexstine ! The code looks good at first glance, but to merge it, we'd need a Behat test as well to ensure it actually does (and keeps doing) what it is supposed to do. Do you care to add such a test? |
@schlessera Can you find another contributor to implement the test? I just don't have time at the moment and I'm sure you are probably in the same boat. Maybe one for next CLI meeting? Thanks. |
@alexstine Changes reverted in 10b75d3 was correct. |
…add/mu-plugin-title
@wojsmol Better now? Just refreshed the fork/branch. |
@alexstine LGTM now. Tests are requiring @schlessera approval to run. |
@wojsmol These check fails don't look related to my changes. Maybe worth a re-run? |
Should we also add support for descriptions? Tests are all passing now btw |
Nothing like all green checks. 👍 If you think it is a good idea, I can try to get descriptions working or can handle in another PR. |
If you're up for it, that would be great. Can be in this PR or a new one, whatever works best for you. Code-wise it should be mostly copy & paste |
…command into add/mu-plugin-title
@swissspidy Done. Not sure if the tests will pass but hopefully so. Gave this a test on my test server, seems solid enough. |
Currently, only name is populated for mu-plugins. This PR will also fill in the title and add the description.