Merge pull request #115 from GeoJunkie/fix/bad-plugin-slugs-warning

wp-cli · Sep 11, 2022 · 80713ba · 80713ba
2 parents f6babbd + ff9a338
commit 80713ba
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 0 deletions.
diff --git a/features/language-plugin.feature b/features/language-plugin.feature
@@ -20,6 +20,16 @@ Feature: Manage translation files for a WordPress install
       | en_US     | English (United States) | active        |
       | en_GB     | English (UK)            | uninstalled   |
 
+    When I try `wp language plugin list not-a-plugin --format=json`
+    Then STDOUT should be:
+      """
+      []
+      """
+    And STDERR should contain:
+      """
+      Warning: Plugin 'not-a-plugin' not found.
+      """
+
     When I try `wp language plugin is-installed hello-dolly en_GB`
     Then the return code should be 1
     And STDERR should be empty

diff --git a/features/language-theme.feature b/features/language-theme.feature
@@ -19,6 +19,16 @@ Feature: Manage translation files for a WordPress install
       | en_US     | English (United States) | active        |
       | en_GB     | English (UK)            | uninstalled   |
 
+    When I try `wp language theme list not-a-theme --format=json`
+    Then STDOUT should be:
+      """
+      []
+      """
+    And STDERR should contain:
+      """
+      Warning: Theme 'not-a-theme' not found.
+      """
+
     When I try `wp language theme is-installed twentyten en_GB`
     Then the return code should be 1
     And STDERR should be empty

diff --git a/src/Plugin_Language_Command.php b/src/Plugin_Language_Command.php
@@ -109,8 +109,14 @@ public function list_( $args, $assoc_args ) {
 		$current_locale = get_locale();
 
 		$translations = array();
+		$plugins      = new \WP_CLI\Fetchers\Plugin();
 
 		foreach ( $args as $plugin ) {
+			if ( ! $plugins->get( $plugin ) ) {
+				WP_CLI::warning( "Plugin '{$plugin}' not found." );
+				continue;
+			}
+
 			$installed_translations = $this->get_installed_languages( $plugin );
 			$available_translations = $this->get_all_languages( $plugin );
 

diff --git a/src/Theme_Language_Command.php b/src/Theme_Language_Command.php
@@ -114,8 +114,15 @@ function( $file ) {
 		$current_locale = get_locale();
 
 		$translations = array();
+		$themes       = new \WP_CLI\Fetchers\Theme();
 
 		foreach ( $args as $theme ) {
+
+			if ( ! $themes->get( $theme ) ) {
+				WP_CLI::warning( "Theme '{$theme}' not found." );
+				continue;
+			}
+
 			$installed_translations = $this->get_installed_languages( $theme );
 			$available_translations = $this->get_all_languages( $theme );