Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change activate command #23

Closed
swissspidy opened this issue Dec 30, 2017 · 3 comments
Closed

Change activate command #23

swissspidy opened this issue Dec 30, 2017 · 3 comments

Comments

@swissspidy
Copy link
Member

swissspidy commented Dec 30, 2017

Currently, there's wp language core activate and --activate flags for the other commands.

Activating a language is nothing more than wp option update WPLANG <locale> and checking whether that language actually exists.

In #21, I started working on subcommands for plugins and themes. Activating a language is a global action per site. One cannot activate language X for plugin A and language Y for plugin B.

Should wp language core activate be renamed to wp language activate or wp language switch? See #21 (comment)

@swissspidy
Copy link
Member Author

@schlessera suggested wp site switch-language ... today to distinguish this from the wp language command which deals with language files, not database settings.

@GaryJones
Copy link

GaryJones commented Jul 20, 2018

For those looking for it, the wp site command is here:

https://github.com/wp-cli/entity-command/blob/master/src/Site_Command.php

However, like https://github.com/wp-cli/checksum-command/blob/89a319440651f2867f282339c2223cfe5e9cc3fb/checksum-command.php shows, it's possible for one package to add a command that would typically be part of another package (i.e. this repo could add a wp site switch-language command)

swissspidy added a commit that referenced this issue Jul 30, 2018
@swissspidy
Copy link
Member Author

Fixed in #29, where I introduced wp site switch-language and adding a deprecation warning to wp language core activate

schlessera pushed a commit that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants