-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme tests to remove P2 and use TwentyTwelve #336
Conversation
4acb1b9
to
2879a27
Compare
@ernilambar Do you know what the random failure is? |
@danielbachhuber Are you referring to this https://github.com/wp-cli/scaffold-command/actions/runs/8764755673/job/24143111683?pr=336 ? In PHP 8.4 tests are failing as WP does not support PHP 8.4 yet. |
Earlier we had
I used |
I think the failure is just because of the deprecation warnings emitted on PHP 8.4. They are fixed in WP trunk, but the test is installing the latest stable (6.5). This will be resolved automatically once 6.6 is released this summer. Note that PHP 8.4 tests are explicitly marked as allowed to fail because it's still in alpha (release is in November). |
@swissspidy Thanks for the clarification! |
Replace P2 theme with TwentyTwelve in feature tests
Related wp-cli/wp-cli-tests#200