Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme tests to remove P2 and use TwentyTwelve #336

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Apr 19, 2024

Replace P2 theme with TwentyTwelve in feature tests

Related wp-cli/wp-cli-tests#200

@ernilambar ernilambar marked this pull request as ready for review April 19, 2024 06:18
@ernilambar ernilambar requested a review from a team as a code owner April 19, 2024 06:18
@danielbachhuber
Copy link
Member

@ernilambar Do you know what the random failure is?

@ernilambar
Copy link
Member Author

@danielbachhuber Are you referring to this https://github.com/wp-cli/scaffold-command/actions/runs/8764755673/job/24143111683?pr=336 ? In PHP 8.4 tests are failing as WP does not support PHP 8.4 yet.

@ernilambar
Copy link
Member Author

Earlier we had wp theme install p2 --activate. When I changed p2 to twentytwelve, like wp theme install twentytwelve --activate, there was some error as in older version of WP there is already TwentyTwelve installed. So I changed it to

Given I try `wp theme install twentytwelve --activate --force`

I used try to suppress that error. May be adding --force would have been enough.

@swissspidy
Copy link
Member

I think the failure is just because of the deprecation warnings emitted on PHP 8.4. They are fixed in WP trunk, but the test is installing the latest stable (6.5).

This will be resolved automatically once 6.6 is released this summer.

Note that PHP 8.4 tests are explicitly marked as allowed to fail because it's still in alpha (release is in November).

@swissspidy swissspidy added this to the 2.3.0 milestone Apr 23, 2024
@danielbachhuber
Copy link
Member

@swissspidy Thanks for the clarification!

@danielbachhuber danielbachhuber merged commit 40b98b5 into wp-cli:main Apr 23, 2024
37 of 38 checks passed
@ernilambar ernilambar deleted the update-theme-tests branch April 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants