Clarify help text and error messages for invalid <dir> values #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
requested changes
Jun 2, 2017
src/ScaffoldPackageCommand.php
Outdated
| } | ||
|
|
||
| if ( ! file_exists( $package_dir . '/composer.json' ) ) { | ||
| WP_CLI::error( 'Invalid package directory. composer.json file must be present.' ); | ||
| } |
There was a problem hiding this comment.
Given the repetition of code, what do you think about creating self::check_package_dir( $package_dir ), and abstracting these error checks to it?
|
I've enabled the setting for Circle to build forked pull requests too. |
|
Something's up with Circle CI |
@johnbillion You'll need to push first, and then it will build the next push. |
danielbachhuber
approved these changes
Jun 21, 2017
schlessera
pushed a commit
that referenced
this pull request
Aug 9, 2022
Clarify help text and error messages for invalid <dir> values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the help text and adds clearer error messages relating to the
<dir>flag.