Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleCI badge in README.md #205

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Update CircleCI badge in README.md #205

merged 1 commit into from
Aug 8, 2022

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Aug 8, 2022

No description provided.

@wojsmol wojsmol requested a review from a team as a code owner August 8, 2022 13:19
@danielbachhuber danielbachhuber changed the title Update CicreCI badge in README.md Update CircleCI badge in README.md Aug 8, 2022
danielbachhuber
danielbachhuber approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wojsmol !

The URL is dynamically generated, so we'll need to fix #204 for the change to be persistent.

We can land this for now, though.

@danielbachhuber danielbachhuber added this to the 2.0.3 milestone Aug 8, 2022
@danielbachhuber danielbachhuber merged commit 7c42917 into wp-cli:main Aug 8, 2022
@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 8, 2022

@danielbachhuber This is for this repo README.md badge not for generated README.md file.

@wojsmol wojsmol deleted the fix/update-readme branch August 8, 2022 13:26
@danielbachhuber
Copy link
Member

This is for this repo README.md badge not for generated README.md file.

@wojsmol Yep! In the past at least, the README.md for this repo was dynamically generated.

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 8, 2022

@danielbachhuber You are right this repo README.md is automatically generated using this command - see my comment #204 (comment).

schlessera pushed a commit that referenced this pull request Aug 9, 2022
@danielbachhuber
Merge pull request #205 from wojsmol/fix/update-readme
e5a4b7b 
Update CircleCI badge in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
scope:documentation
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wojsmol @danielbachhuber