Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PHP deprecation notices in PHP 8.1.x #5899

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

christianwach
Copy link
Contributor

Please see #5898 for details.

tl;dr In versions of PHP greater than 8.1.x, when Utils\http_request() fails, then PHP Deprecated notices are written to the logs. Passing (int) 0 is compatible with the signature of the RuntimeException constructor and avoids the warnings.

Since there are no functional changes in this PR, I haven't included tests.

@christianwach christianwach requested a review from a team as a code owner February 8, 2024 12:48
@swissspidy swissspidy added this to the 2.10.0 milestone Feb 8, 2024
@schlessera schlessera removed this from the 2.10.0 milestone Feb 8, 2024
@swissspidy swissspidy modified the milestone: 2.10.0 Feb 8, 2024
@danielbachhuber danielbachhuber added this to the 2.11.0 milestone Feb 10, 2024
@danielbachhuber danielbachhuber merged commit e516414 into wp-cli:main Feb 10, 2024
55 of 65 checks passed
@christianwach christianwach deleted the issue-5898 branch April 30, 2024 10:04
@christianwach
Copy link
Contributor Author

@schlessera Little bit sad I didn't get the "WP-CLI Contributor" badge on my wporg profile for this and #5897 🤷 Ah well.

@swissspidy
Copy link
Member

swissspidy commented Aug 20, 2024

@christianwach These badges are not granted automatically and we do not have the capacity nor technical ability to find everyone's WordPress.org profile and assign badges ourselves. You can however request a badge at https://profiles.wordpress.org/associations/cli-contributor/request-membership/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants