Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Infinite loop when Flexible Content has an row with no fields #91

Closed
thelucre opened this issue Nov 15, 2019 · 3 comments · Fixed by #94
Closed

Infinite loop when Flexible Content has an row with no fields #91

thelucre opened this issue Nov 15, 2019 · 3 comments · Fixed by #94
Assignees
@jasonbahl
Labels
Needs to be reproduced status: awaiting author response Additional information has been requested from the author

Comments

@thelucre
Copy link

thelucre commented Nov 15, 2019 •
edited
Loading

Just freshly installed WP GraphQL 0.4.0 and WP GraphQL ACF 0.3.1 and am getting memory issues when hitting any /graphql endpoint. When deactivating the WP GraphQL ACF plugin, the queries work again.

[14-Nov-2019 23:59:13 UTC] PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 65536 bytes) in [redacted]/wp-content/plugins/wp-graphql-0.4.0/src/Registry/TypeRegistry.php on line 131
[15-Nov-2019 00:00:43 UTC] PHP Fatal error:  Allowed memory size of 2147483648 bytes exhausted (tried to allocate 139264 bytes) in [redacted]/wp-content/plugins/wp-graphql-0.4.0/src/Registry/TypeRegistry.php on line 131

I later got this message:

[15-Nov-2019 00:38:12 UTC] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 28672 bytes) in [redacted]/wp-content/plugins/wp-graphql-acf-0.3.1/src/class-config.php on line 779

Which leads me to believe it's flexible content.

I had a single Flexible content field in my GraphQL response as acfModules. I removed it from the response and it's all working now.

Any thoughts?
@thelucre thelucre changed the title Breaks GraphQL queries (memory leak?) on WP GraphQL 0.4.0 Breaks GraphQL queries when using Flexible Content Nov 15, 2019
@thelucre thelucre changed the title Breaks GraphQL queries when using Flexible Content Infinite loop when Flexible Content has an row with no fields Nov 15, 2019
@jasonbahl
Copy link
Contributor

@thelucre looking into this.

@jasonbahl jasonbahl self-assigned this Dec 3, 2019
@jasonbahl
Copy link
Contributor

@thelucre can you provide a JSON export of the ACF Field Group that was problematic so I can attempt to replicate?

@jasonbahl jasonbahl added status: awaiting author response Additional information has been requested from the author Needs to be reproduced labels Dec 3, 2019
jasonbahl added a commit to jasonbahl/wp-graphql-acf that referenced this issue Dec 3, 2019
@jasonbahl
wp-graphql#91 - Don't add flex fields to the Schema if there are no l…
3ede9a7 
…ayouts configured
@jasonbahl jasonbahl mentioned this issue Dec 3, 2019
Merged
jasonbahl added a commit that referenced this issue Dec 3, 2019
@jasonbahl
Merge pull request #94 from jasonbahl/bug/#91-flex-field-with-no-layo…
bc20b9d 
…ut-causes-issues

#91 - Don't add flex fields to the Schema if there are no layouts configured
@jasonbahl
Copy link
Contributor

@thelucre I think PR #94 addresses this, but if you find otherwise we can re-open and investigate further.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonbahl jasonbahl

Labels
Needs to be reproduced status: awaiting author response Additional information has been requested from the author
Projects
None yet
Milestone
No milestone
2 participants
@jasonbahl @thelucre