Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Feature/acf required #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrewminion-luminfire
Copy link

If a field group is set to not display in GraphQL, it seems that the GraphQL name should not be required.

This change adds PHP and JS functionality to toggle the name field required attribute based on the “Show in GraphQL” field setting.

@jasonbahl
Copy link
Contributor

Oh nice! I like this idea for sure.

I think there's a lot we can do with JS on that page to help users, like make sure the GraphQL Field Name is unique in the Schema as well.

I'll review this shortly.

@andrewminion-luminfire
Copy link
Author

Just updated wp_register_script to optimize the JS loading.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants