Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format of list of IPs for WP Rocket so that there is one IP pe… #60

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

MathieuLamiot
Copy link

Description

Changes the text format returned by the wprocket-ips command.

Fixes #59

Type of change

Please delete options that are not relevant.

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No grooming.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

To be tested in production.

Please describe any additional tests you performed.

@MathieuLamiot MathieuLamiot self-assigned this Dec 28, 2023
@MathieuLamiot MathieuLamiot merged commit 999443a into develop Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change format of list of IPs for WP Rocket so that there is one IP per line
1 participant