Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up shall consider using 2020 whenever we change the theme while testing #173

Closed
Mai-Saad opened this issue Nov 21, 2024 · 4 comments · Fixed by #178
Closed

Clean up shall consider using 2020 whenever we change the theme while testing #173

Mai-Saad opened this issue Nov 21, 2024 · 4 comments · Fixed by #178
Assignees

Comments

@Mai-Saad
Copy link
Contributor

Some tests may change active theme like in delayjs tests. At the same time, our LCP results are based on 2020 as an active theme.

Thus As a QA engineer, I'd like to consider the test clean-up to reset the system to its original state like before the test to have consistent results.

@hanna-meda
Copy link
Contributor

Note:
When completing this task, please also consider removing the following line, as it will no longer be necessary there. Thank you.

@jeawhanlee
Copy link
Contributor

Scope a solution ✅

Estimate the effort ✅
[S]

@Mai-Saad
Copy link
Contributor Author

And lastly just like @hanna-meda stated above, remove this line as we will now activate 2020 theme before each scenario.

@jeawhanlee @hanna-meda which theme do we switch to here? is this step just validating that new theme is activated successfully after switching?

@hanna-meda
Copy link
Contributor

which theme do we switch to here? is this step just validating that new theme is activated successfully after switching?

@Mai-Saad Here, as last step of scenario, we switch back to the 2020 theme to ensure the environment is left with the default theme. However, since a clean-up process will now handle this, this step becomes obsolete.

@hanna-meda hanna-meda self-assigned this Nov 25, 2024
@hanna-meda hanna-meda linked a pull request Nov 25, 2024 that will close this issue
16 tasks
hanna-meda added a commit that referenced this issue Nov 27, 2024
…to-default-theme

Fixes #173 Adds to clean-up the switch theme via WP CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants