Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #42: Smoke/Regression test for delayjs script #45

Merged
merged 24 commits into from
Feb 15, 2024

Conversation

jeawhanlee
Copy link
Contributor

Description

Added Smoke/VR test for delayjs

Fixes #42

Type of change

  • New feature (non-breaking change which adds functionality).

Is the solution different from the one proposed during the grooming?

Slightly different, The grooming proposed a solution of automating the the whole theme switching before creating a backstop reference for VR testing but it got complicated to implement so what we currently have is separate script command for various test theme candidate.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@jeawhanlee jeawhanlee self-assigned this Feb 7, 2024
@MathieuLamiot MathieuLamiot requested a review from a team February 9, 2024 14:40
@MathieuLamiot MathieuLamiot mentioned this pull request Feb 13, 2024
6 tasks
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Feb 13, 2024

@jeawhanlee Thanks for the PR. Please find usability test notes below.
1- Currently, For scenario 1. We need to use cmd to run the test against specific theme i.e npm run test:delayjs:astra=> We need to enhance that (may be other GH) so single cmd i.e npm run test:delayjs will run the same scenario n times , each with specific theme
2- When we have theme x active and we run vs theme y, test will fail then if we rerun will pass => further investigation is needed here => update : now retesting this, sometimes pass, others fail so we shall keep an eye on this for upcoming execution

@Mai-Saad Mai-Saad merged commit 798de5f into trunk Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a test engineer, I'd like to run smoke/regression test for new Delay JS script using the tool
3 participants