-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.18: the local hosted google font file shall match the required structure #7143
Comments
@wp-media/engineering-plugin-team Was there any reason to have that kind of structure with hash? |
The font is stored at the same level as the CSS file, but that can be updated |
Scope a solutionwe need to modify
in order to take into account the fonts folder to follow the structure /wp-content/cache/fonts/1/google-font/fonts/
Finally, in here:
We need to adapt the new path so we are modifying correctly the content of the css file to include the correct font file. EffortS |
I'd like to suggest a couple of changes concerning the file structure:
That way we will be able to clean the files individually in an easier way What Gael proposed in term of solution is a good basis to do that, with a few more changes needed in the frontend controller. |
Describe the bug
Local hosted google font shall meet the expectations mentioned here #7062 (comment)
currently:
1- no /fonts after /google-fonts
2- hash is added to the font file (while hash was mentioned only for CSS file)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
URL like
https://new.rocketlabsqa.ovh/wp-content_new/cache/fonts/1/google-font/fonts/s/anonymouspro/v21/rP2Bp2a15UIB7Un-bOeISG3pHl829RH9.woff2
instead ofhttps://new.rocketlabsqa.ovh/wp-content_new/cache/fonts/1/google-font/b/0/e/c20c0038dca463f0adee9b315f221/s/anonymouspro/v21/rP2Bp2a15UIB7Un-bOeISG3pHl829RH9.woff2
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
slack thread https://wp-media.slack.com/archives/CUKB44GNN/p1732610252901139
The text was updated successfully, but these errors were encountered: