Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18: Preconnect for Google fonts isnot removed when Host Google fonts locally option is enabled #7146

Open
Mai-Saad opened this issue Nov 27, 2024 · 0 comments · Fixed by #7158
Assignees
Labels
module: google fonts priority: high Issues which should be resolved as quickly as possible severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@Mai-Saad
Copy link
Contributor

Describe the bug
While Host google fonts option is on, we shouldn't add preconnect/prefetch for Google fonts and if it was there , we shall remove it as mentioned here #7066. However, it is still there <link href='https://fonts.gstatic.com/' crossorigin rel='preconnect' />

To Reproduce
Steps to reproduce the behavior:

  1. WPR 3.18-alpha1 installed and activated
  2. Enable Host google fonts locally
  3. Visit page with GFs i.e https://new.rocketlabsqa.ovh/combine-v1-v2-fonts/
  4. check page source => <link href='https://fonts.gstatic.com/' crossorigin rel='preconnect' /> is there

Expected behavior

  • When the feature is enabled, will remove all preconnect/prefetch links related to the Google Fonts
    fonts.gstatic.com delivers the font files
    fonts.googleapis.com delivers font CSS
  • We'll introduce a filter to disable this behavior

Screenshots
If applicable, add screenshots to help explain your problem.
Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Mai-Saad Mai-Saad added the type: bug Indicates an unexpected problem or unintended behavior label Nov 27, 2024
@Mai-Saad Mai-Saad changed the title 3.18: Preconnect for Google fonts isnot removed when Host locally option is enabled 3.18: Preconnect for Google fonts isnot removed when Host Google fonts locally option is enabled Nov 27, 2024
@piotrbak piotrbak added this to the 3.18 milestone Nov 27, 2024
@Mai-Saad Mai-Saad added priority: high Issues which should be resolved as quickly as possible severity: moderate Feature isn't working as expected but has work around to get same value module: google fonts labels Nov 28, 2024
Miraeld added a commit that referenced this issue Dec 1, 2024
@Miraeld Miraeld self-assigned this Dec 2, 2024
@hanna-meda hanna-meda self-assigned this Dec 2, 2024
hanna-meda added a commit that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: google fonts priority: high Issues which should be resolved as quickly as possible severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
4 participants